The Shift variance journal posted multiple times for the same shift ID. This is caused when the below error is received on the shift close screen. Refer steps to replicate:

1. Click on Close Shit
2. Enter Till Amount
3. Click Next
4. Accept Variance Amount
5. Click Full Close
6. Error received - Refer to Figure 1.
7. Click OK
8. The screen remains open
9. The variance is created depending on the time's user has clicked "ok" on that error. Refer to Figure 2.

Figure 2:

PART A - Development work for this case has been completed.

1. The change will be available in version:12.42.0519

2. The following changes were made(Include Database object names, Program classes, and any other relevant information):

1. Separated the Shift close process into "ShiftPaymentReconcile" and "ShiftClose"
2. When doing a PARTIAL CLOSE, we call the "ShiftPaymentMethodReconcile" function for each payment method that is being reconciled. The following happens at the end of the reconciliation process:
   1. The reconciliation report is printed
3. When doing a FULL CLOSE, we call the "ShiftPaymentReconcile" function for each payment method that is being reconciled, then we call the "Close Shift" function. At this stage, the following happens:
   1. The shift is marked as CLOSED
   2. The reconciliation report is printed
   3. The cashier is charged any variance based on the "Variance Buffer" setting
   4. The user is logged out
4. Added transaction handling so that failure to reconcile one payment method will roll back all payment methods allowing the user to correct the issue and try again
5. Printing report Errors allows you to continue with Close Shift as the error could be "out of Paper", "Printer Off" issues which should not affect the Shift. Shift report can be RE-printed from Reports.
6. Corrected issues with Variance Charge Tax amounts
7. When creating a CUSTOMER for the Cashier to charge the Shift Variance, we use all details from the User Account to create the customer.

3. Affected Areas:

1. Shift Close, Partial and Full Close Functions
2. Shift Variance Charge transaction
3. Tax components of SURCHARGE in Shift Variance Transaction

4. The issue was caused by:

1. Incomplete design of Partial and Full close functionality

5. Notes: 
6. Next Step (Review and System Test (Developer) -> UAT (Quality) -> Documentation): UAT